Replace lodash with es-toolkit#224
Open
dayongkr wants to merge 1 commit intoreact-hook-form:masterfrom
Open
Conversation
dayongkr
commented
Jul 10, 2025
| const nativeFields = flatFieldNames.reduce((prev, name) => { | ||
| const field = get(control._fields, name)?._f; | ||
| prev[name] = get(field, 'ref')?.type; | ||
| prev[name] = (get(field, 'ref') as any)?.type; |
Author
There was a problem hiding this comment.
In this project, you used an older version of @types/lodash where get was implemented to return any. However, es-toolkit/compat matches type compatibility based on the latest @types/lodash, which broke this code. So I explicitly used as to cast the type as it was previously inferred(any) in the older version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace lodash with es-toolkit for better performance and smaller bundle size
Summary
This PR replaces lodash dependencies with es-toolkit to improve performance and reduce bundle size in dev-tools.
Changes
getfunction: Reduced from 1,279 lines to 175 linesisObjectfunction: Using es-toolkit's lodash-compatible versionisUndefined→ Direct JavaScript syntax (target === undefined)Performance Improvements
Why es-toolkit?
Technical Details
The
getfunction optimization was achieved by:Testing
Future Plans
This is part of our ongoing performance improvement initiative. We recommend migrating from the unmaintained lodash to the modern, performant es-toolkit.